Skip to content

chore: update optimizer_runs to reduce contract size#194

Merged
rjan90 merged 2 commits intomainfrom
phi/update-optimizer-runs
Sep 11, 2025
Merged

chore: update optimizer_runs to reduce contract size#194
rjan90 merged 2 commits intomainfrom
phi/update-optimizer-runs

Conversation

@rjan90
Copy link
Contributor

@rjan90 rjan90 commented Sep 11, 2025

With the current settings, the PDP contract is above the size limit:

forge build --sizes
╭------------------------------------+------------------+-------------------+--------------------+---------------------╮
| Contract                           | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
+======================================================================================================================+
| Address                            | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| BadListener                        | 2,518            | 2,545             | 22,058             | 46,607              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| BitOps                             | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| Cids                               | 235              | 265               | 24,341             | 48,887              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| ERC1967Proxy                       | 141              | 723               | 24,435             | 48,429              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| ERC1967Utils                       | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| Errors                             | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| ExtraDataListener                  | 3,299            | 3,326             | 21,277             | 45,826              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| Hashes                             | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| Math                               | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| MerkleProve                        | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| MerkleVerify                       | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| MockStorageProviderChangedListener | 2,525            | 2,552             | 22,051             | 46,600              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| MyERC1967Proxy                     | 141              | 701               | 24,435             | 48,451              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| PDPFees                            | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| PDPRecordKeeper                    | 1,681            | 1,708             | 22,895             | 47,444              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| PDPVerifier                        | 24,946           | 25,160            | -370               | 23,992              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| Panic                              | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| ProofUtil                          | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| PythStructs                        | 57               | 81                | 24,519             | 49,071              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| SafeCast                           | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| SignedMath                         | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| SimplePDPService                   | 7,641            | 7,850             | 16,935             | 41,302              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| StorageSlot                        | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| Strings                            | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| SumTreeInternalTestPDPVerifier     | 25,086           | 25,300            | -510               | 23,852              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| TestingRecordKeeperService         | 8,095            | 8,122             | 16,481             | 41,030              |
╰------------------------------------+------------------+-------------------+--------------------+---------------------╯

Error: some contracts exceed the runtime size limit (EIP-170: 24576 bytes)

Reducing the optimizer_runs to 200 makes it pass:

╭------------------------------------+------------------+-------------------+--------------------+---------------------╮
| Contract                           | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
+======================================================================================================================+
| Address                            | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| BadListener                        | 1,729            | 1,756             | 22,847             | 47,396              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| BitOps                             | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| Cids                               | 150              | 179               | 24,426             | 48,973              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| ERC1967Proxy                       | 130              | 712               | 24,446             | 48,440              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| ERC1967Utils                       | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| Errors                             | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| ExtraDataListener                  | 2,411            | 2,438             | 22,165             | 46,714              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| Hashes                             | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| Math                               | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| MerkleProve                        | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| MerkleVerify                       | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| MockStorageProviderChangedListener | 1,761            | 1,788             | 22,815             | 47,364              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| MyERC1967Proxy                     | 130              | 690               | 24,446             | 48,462              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| PDPFees                            | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| PDPRecordKeeper                    | 1,319            | 1,346             | 23,257             | 47,806              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| PDPVerifier                        | 18,532           | 18,746            | 6,044              | 30,406              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| Panic                              | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| ProofUtil                          | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| PythStructs                        | 57               | 81                | 24,519             | 49,071              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| SafeCast                           | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| SignedMath                         | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| SimplePDPService                   | 5,286            | 5,495             | 19,290             | 43,657              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| StorageSlot                        | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| Strings                            | 57               | 85                | 24,519             | 49,067              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| SumTreeInternalTestPDPVerifier     | 18,642           | 18,856            | 5,934              | 30,296              |
|------------------------------------+------------------+-------------------+--------------------+---------------------|
| TestingRecordKeeperService         | 5,524            | 5,551             | 19,052             | 43,601              |
╰------------------------------------+------------------+-------------------+--------------------+---------------------╯

@rjan90
chore: update optimizer_runs to reduce contract size
c058d78 
chore: update optimizer_runs to reduce contract size
@rjan90 rjan90 requested a review from ZenGround0 September 11, 2025 14:06
@FilOzzy FilOzzy added this to FOC Sep 11, 2025
@github-project-automation github-project-automation bot moved this to 📌 Triage in FOC Sep 11, 2025
@rjan90
Copy link
Contributor Author

rjan90 commented Sep 11, 2025

That said, I´m not sure what the "optimal" amount of runs is here, if we want to publish the updated PDP contract on Mainnet

@rjan90 rjan90 requested a review from wjmelements September 11, 2025 14:07
@rjan90 rjan90 moved this from 📌 Triage to 🐱 Todo in FOC Sep 11, 2025
@rjan90 rjan90 moved this from 🐱 Todo to 🔎 Awaiting review in FOC Sep 11, 2025
@rjan90 rjan90 moved this to 🔎 Awaiting review in PDP Sep 11, 2025
wjmelements
wjmelements reviewed Sep 11, 2025
View reviewed changes
@wjmelements
Copy link
Contributor

wjmelements commented Sep 11, 2025

That said, I´m not sure what the "optimal" amount of runs is here, if we want to publish the updated PDP contract on Mainnet

For Ethereum, optimizer runs is how many times the code is expected to run. There are tradeoffs the optimizer can make for size vs execution.

I have noticed that, on Filecoin, a smaller contract seems to also use less gas during execution, which isn't true in the normal EVM. I have a draft to profile gas on FEVM but I haven't had bandwidth to complete that for the last several weeks. If that work were complete we could tune this parameter to optimize for FEVM gas.

@rjan90
chore: update optimizer_runs to 1
69d578a 
chore: update optimizer_runs to 1
@github-project-automation github-project-automation bot moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FOC Sep 11, 2025
@rjan90 rjan90 merged commit 4214bd2 into main Sep 11, 2025
2 checks passed
@rjan90 rjan90 deleted the phi/update-optimizer-runs branch September 11, 2025 15:10
@github-project-automation github-project-automation bot moved this from 🔎 Awaiting review to 🎉 Done in PDP Sep 11, 2025
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjmelements wjmelements wjmelements approved these changes

@ZenGround0 ZenGround0 Awaiting requested review from ZenGround0

Assignees

No one assigned

Labels

None yet

Projects

FOC
Status: 🎉 Done
PDP
Status: 🎉 Done

Milestone

M2.5: Filecoin Warm Storage Service A...

Development

Successfully merging this pull request may close these issues.

2 participants

@rjan90 @wjmelements